Modify code to prepare HTTPS migration#3800
Closed
louisjdmartin wants to merge 7 commits into
Closed
Conversation
fstagni
reviewed
Aug 20, 2018
| Placeholder client to speak with ConfigurationServer. | ||
| """ | ||
|
|
||
| pass |
Contributor
There was a problem hiding this comment.
Using here
self.setServer('Configuration/Server')
wouldn't work?
Contributor
Author
There was a problem hiding this comment.
Sometime component need to provide an explicit url (for example, the master configuration server choose a slave server to ping it). This line may override the url given from **kwargs with a random url from CS.
But I can add this:
def __init__(self, **kwargs):
if 'url' not in kwargs:
kwargs['url'] = 'Configuration/Server'
super(ConfigurationServerClient, self).__init__(**kwargs)
So by default it use an URL from the CS, but it still possible to give another URL on the keywords arguments.
Contributor
|
The release notes should mention which DIRAC system is involved. |
louisjdmartin
force-pushed
the
pr_to_dirac
branch
2 times, most recently
from
4199422 to
6f8b416
Compare
CS: add specific client and use it in CSAPI
louisjdmartin
force-pushed
the
pr_to_dirac
branch
from
6f8b416 to
c69f0d4
Compare
Contributor
|
This PR should be dropped as replcaed by #3815, shouldn't it ? |
Contributor
|
Yes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the last meeting here some change that can already be done in DIRAC for HTTPS migration.
It also include a whoami method for services.
BEGINRELEASENOTES
*CS
CHANGE: Separation between threads an logic in Refresher
CHANGE: Separation between threads an logic in ServiceInterface
NEW: Client for Configuration/Server
*Core
NEW: adding new way to detect url in Core.Base.Client (using a kwargs)
NEW: a simple whoami for services
ENDRELEASENOTES